Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-08 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Mon, Oct 07, 2019 at 12:11:31PM +0200, Toke Høiland-Jørgensen wrote: >> Alexei Starovoitov writes: >> >> > On Fri, Oct 04, 2019 at 07:22:41PM +0200, Toke Høiland-Jørgensen wrote: >> >> From: Toke Høiland-Jørgensen >> >> >> >> This adds support for injecting cha

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-08 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On Mon, Oct 07, 2019 at 12:11:31PM +0200, Toke Høiland-Jørgensen wrote: >> Alexei Starovoitov writes: >> > On Fri, Oct 04, 2019 at 07:22:41PM +0200, Toke Høiland-Jørgensen wrote: >> >> From: Toke Høiland-Jørgensen >> >> >> >> This adds support for injecting chain call

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-07 Thread Alexei Starovoitov
On Mon, Oct 07, 2019 at 12:11:31PM +0200, Toke Høiland-Jørgensen wrote: > Alexei Starovoitov writes: > > > On Fri, Oct 04, 2019 at 07:22:41PM +0200, Toke Høiland-Jørgensen wrote: > >> From: Toke Høiland-Jørgensen > >> > >> This adds support for injecting chain call logic into eBPF programs befo

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-07 Thread Daniel Borkmann
On Mon, Oct 07, 2019 at 12:11:31PM +0200, Toke Høiland-Jørgensen wrote: > Alexei Starovoitov writes: > > On Fri, Oct 04, 2019 at 07:22:41PM +0200, Toke Høiland-Jørgensen wrote: > >> From: Toke Høiland-Jørgensen > >> > >> This adds support for injecting chain call logic into eBPF programs before

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-07 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Fri, Oct 04, 2019 at 07:22:41PM +0200, Toke Høiland-Jørgensen wrote: >> From: Toke Høiland-Jørgensen >> >> This adds support for injecting chain call logic into eBPF programs before >> they return. The code injection is controlled by a flag at program load >> tim

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-06 Thread Alexei Starovoitov
On Fri, Oct 04, 2019 at 07:22:41PM +0200, Toke Høiland-Jørgensen wrote: > From: Toke Høiland-Jørgensen > > This adds support for injecting chain call logic into eBPF programs before > they return. The code injection is controlled by a flag at program load > time; if the flag is set, the verifier

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-06 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Sat, 05 Oct 2019 12:29:14 +0200, Toke Høiland-Jørgensen wrote: >> >> +static int bpf_inject_chain_calls(struct bpf_verifier_env *env) >> >> +{ >> >> + struct bpf_prog *prog = env->prog; >> >> + struct bpf_insn *insn = prog->insnsi; >> >> + int i, cnt, delta = 0, ret =

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-05 Thread Jakub Kicinski
On Sat, 05 Oct 2019 12:29:14 +0200, Toke Høiland-Jørgensen wrote: > >> +static int bpf_inject_chain_calls(struct bpf_verifier_env *env) > >> +{ > >> + struct bpf_prog *prog = env->prog; > >> + struct bpf_insn *insn = prog->insnsi; > >> + int i, cnt, delta = 0, ret = -ENOMEM; > >> + const int in

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-05 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: >> diff --git a/include/linux/bpf.h b/include/linux/bpf.h >> index 5b9d22338606..753abfb78c13 100644 >> --- a/include/linux/bpf.h >> +++ b/include/linux/bpf.h >> @@ -383,6 +383,7 @@ struct bpf_prog_aux { >> struct list_head ksym_lnode; >> const struct bpf_prog_ops

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-05 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Fri, 04 Oct 2019 19:22:41 +0200, Toke Høiland-Jørgensen wrote: >> From: Toke Høiland-Jørgensen >> >> This adds support for injecting chain call logic into eBPF programs before >> they return. The code injection is controlled by a flag at program load >> time; if the

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-04 Thread Jakub Kicinski
On Fri, 04 Oct 2019 19:22:41 +0200, Toke Høiland-Jørgensen wrote: > From: Toke Høiland-Jørgensen > > This adds support for injecting chain call logic into eBPF programs before > they return. The code injection is controlled by a flag at program load > time; if the flag is set, the verifier will a

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-04 Thread kbuild test robot
Hi "Toke, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/bpf-Support-injecting-chain-calls-into-BPF-programs-on-load/20191005-035650 base: https://git.kernel.org/pub/scm/linu

Re: [PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-04 Thread kbuild test robot
Hi "Toke, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/bpf-Support-injecting-chain-calls-into-BPF-programs-on-load/20191005-035650 base: https://git.kernel.org/pub/scm/linux/kern

[PATCH bpf-next v2 1/5] bpf: Support injecting chain calls into BPF programs on load

2019-10-04 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds support for injecting chain call logic into eBPF programs before they return. The code injection is controlled by a flag at program load time; if the flag is set, the verifier will add code to every BPF_EXIT instruction that first does a lookup into a chain