Hi "Toke,

I love your patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    
https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/bpf-Support-injecting-chain-calls-into-BPF-programs-on-load/20191005-035650
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <l...@intel.com>

All errors (new ones prefixed by >>):

   kernel/bpf/core.c: In function '__bpf_prog_free':
>> kernel/bpf/core.c:266:4: error: implicit declaration of function 
>> 'bpf_map_area_free'; did you mean 'bpf_prog_free'? 
>> [-Werror=implicit-function-declaration]
       bpf_map_area_free(array);
       ^~~~~~~~~~~~~~~~~
       bpf_prog_free
   cc1: some warnings being treated as errors

vim +266 kernel/bpf/core.c

   253  
   254  void __bpf_prog_free(struct bpf_prog *fp)
   255  {
   256          if (fp->aux) {
   257                  free_percpu(fp->aux->stats);
   258                  if (fp->aux->chain_progs) {
   259                          struct bpf_array *array = fp->aux->chain_progs;
   260                          int i;
   261  
   262                          for (i = 0; i < BPF_NUM_CHAIN_SLOTS; i++)
   263                                  if (array->ptrs[i])
   264                                          bpf_prog_put(array->ptrs[i]);
   265  
 > 266                          bpf_map_area_free(array);
   267                  }
   268                  kfree(fp->aux);
   269          }
   270          vfree(fp);
   271  }
   272  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to