Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-21 Thread Marek Vasut
On 5/17/20 9:30 PM, David Miller wrote: > From: Andrew Lunn > Date: Sun, 17 May 2020 21:16:35 +0200 > >>> Nevertheless I was going to repeat the performance measurements on a >>> recent kernel but haven't gotten around to that yet because the >>> measurements need to be performed with CONFIG_PREE

Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-17 Thread Marek Vasut
On 5/17/20 9:26 PM, Andrew Lunn wrote: >> So I was already led into reworking the entire series to do this >> inlining once, after V1. It then turned out it's a horrible mess to get >> everything to compile as modules and built-in and then also only the >> parallel/SPI as a module and then the othe

Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-17 Thread David Miller
From: Andrew Lunn Date: Sun, 17 May 2020 21:16:35 +0200 >> Nevertheless I was going to repeat the performance measurements on a >> recent kernel but haven't gotten around to that yet because the >> measurements need to be performed with CONFIG_PREEMPT_RT_FULL to >> be reliable (a vanilla kernel i

Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-17 Thread Andrew Lunn
> So I was already led into reworking the entire series to do this > inlining once, after V1. It then turned out it's a horrible mess to get > everything to compile as modules and built-in and then also only the > parallel/SPI as a module and then the other way around. Maybe consider some trade of

Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-17 Thread Andrew Lunn
> However in terms of performance there's a bigger problem: > > Previously ks8851.c (SPI driver) had 8-bit and 32-bit register accessors. > The present series drops them and performs a 32-bit access as two 16-bit > accesses and an 8-bit access as one 16-bit access because that's what > ks8851_mll.

Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-17 Thread Marek Vasut
On 5/17/20 9:13 AM, Lukas Wunner wrote: > On Sat, May 16, 2020 at 07:02:25PM -0700, David Miller wrote: >>> The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces >>> of silicon, except the former has an SPI interface, while the later has a >>> parallel bus interface. Thus far,

Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-17 Thread Lukas Wunner
On Sat, May 16, 2020 at 07:02:25PM -0700, David Miller wrote: > > The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces > > of silicon, except the former has an SPI interface, while the later has a > > parallel bus interface. Thus far, Linux has two separate drivers for each >

Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-16 Thread Marek Vasut
On 5/17/20 4:02 AM, David Miller wrote: > From: Marek Vasut > Date: Sun, 17 May 2020 02:33:34 +0200 > >> The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces >> of silicon, except the former has an SPI interface, while the later has a >> parallel bus interface. Thus far, Li

Re: [PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-16 Thread David Miller
From: Marek Vasut Date: Sun, 17 May 2020 02:33:34 +0200 > The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces > of silicon, except the former has an SPI interface, while the later has a > parallel bus interface. Thus far, Linux has two separate drivers for each > and they

[PATCH V6 00/20] net: ks8851: Unify KS8851 SPI and MLL drivers

2020-05-16 Thread Marek Vasut
The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces of silicon, except the former has an SPI interface, while the later has a parallel bus interface. Thus far, Linux has two separate drivers for each and they are diverging considerably. This series unifies them into a singl