Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages

2017-05-26 Thread David Ahern
On 5/26/17 2:01 PM, Vlad Yasevich wrote: >> Also, generically the IFLA_EVENT attribute should be considered >> independent of NETDEV_ events. >> >> For example, userspace should be notified if the speed / duplex for a >> device changes, so we could have another one of these -- e.g., >> IFLA_EVENT_S

Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages

2017-05-26 Thread Vlad Yasevich
On 05/26/2017 03:40 PM, David Ahern wrote: > On 5/25/17 9:31 AM, Vladislav Yasevich wrote: >> @@ -911,4 +912,14 @@ enum { >> >> #define IFLA_XDP_MAX (__IFLA_XDP_MAX - 1) >> >> +enum { >> +IFLA_EVENT_UNSPEC, >> +IFLA_EVENT_REBOOT, >> +IFLA_EVENT_FEAT_CHANGE, >> +IFLA_EVENT_BONDI

Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages

2017-05-26 Thread David Ahern
On 5/25/17 9:31 AM, Vladislav Yasevich wrote: > @@ -911,4 +912,14 @@ enum { > > #define IFLA_XDP_MAX (__IFLA_XDP_MAX - 1) > > +enum { > + IFLA_EVENT_UNSPEC, > + IFLA_EVENT_REBOOT, > + IFLA_EVENT_FEAT_CHANGE, > + IFLA_EVENT_BONDING_FAILOVER, > + IFLA_EVENT_NOTIFY_PEERS, > +

[PATCH V5 1/2] rtnl: Add support for netdev event to link messages

2017-05-25 Thread Vladislav Yasevich
When netdev events happen, a rtnetlink_event() handler will send messages for every event in it's white list. These messages contain current information about a particular device, but they do not include the iformation about which event just happened. So, it is impossible to tell what just happen