On 5/26/17 2:01 PM, Vlad Yasevich wrote: >> Also, generically the IFLA_EVENT attribute should be considered >> independent of NETDEV_ events. >> >> For example, userspace should be notified if the speed / duplex for a >> device changes, so we could have another one of these -- e.g., >> IFLA_EVENT_SPEED -- that does not correlate to NETDEV_SPEED since >> nothing internal to the network stack cares about speed changes, or >> perhaps more generically it is IFLA_EVENT_LINK_SETTING. >> > > Ok. We could do a translation between netdev event and IFLA_EVENT attribute > value > earlier (say in rtnetlink_event) and pass that along. This would allow calls > from other places, assuming proper IFLA_EVENT attribute value and translation > is defined. > > Would that address your concerns?
yes. that code re-factoring can be done when it is needed.