Re: [PATCH V3 net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments

2019-08-28 Thread Gregory Rose
On 8/28/2019 2:54 PM, David Miller wrote: From: Greg Rose Date: Tue, 27 Aug 2019 07:58:09 -0700 When IP fragments are reassembled before being sent to conntrack, the key from the last fragment is used. Unless there are reordering issues, the last fragment received will not contain the L4 port

Re: [PATCH V3 net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments

2019-08-28 Thread David Miller
From: Greg Rose Date: Tue, 27 Aug 2019 07:58:09 -0700 > When IP fragments are reassembled before being sent to conntrack, the > key from the last fragment is used. Unless there are reordering > issues, the last fragment received will not contain the L4 ports, so the > key for the reassembled dat

Re: [PATCH V3 net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments

2019-08-27 Thread Gregory Rose
On 8/27/2019 5:33 PM, Pravin Shelar wrote: On Tue, Aug 27, 2019 at 7:58 AM Greg Rose wrote: When IP fragments are reassembled before being sent to conntrack, the key from the last fragment is used. Unless there are reordering issues, the last fragment received will not contain the L4 ports,

Re: [PATCH V3 net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments

2019-08-27 Thread Pravin Shelar
On Tue, Aug 27, 2019 at 7:58 AM Greg Rose wrote: > > When IP fragments are reassembled before being sent to conntrack, the > key from the last fragment is used. Unless there are reordering > issues, the last fragment received will not contain the L4 ports, so the > key for the reassembled datagra

[PATCH V3 net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments

2019-08-27 Thread Greg Rose
When IP fragments are reassembled before being sent to conntrack, the key from the last fragment is used. Unless there are reordering issues, the last fragment received will not contain the L4 ports, so the key for the reassembled datagram won't contain them. This patch updates the key once we ha