On 8/27/2019 5:33 PM, Pravin Shelar wrote:
On Tue, Aug 27, 2019 at 7:58 AM Greg Rose <gvrose8...@gmail.com> wrote:
When IP fragments are reassembled before being sent to conntrack, the
key from the last fragment is used. Unless there are reordering
issues, the last fragment received will not contain the L4 ports, so the
key for the reassembled datagram won't contain them. This patch updates
the key once we have a reassembled datagram.
The handle_fragments() function works on L3 headers so we pull the L3/L4
flow key update code from key_extract into a new function
'key_extract_l3l4'. Then we add a another new function
ovs_flow_key_update_l3l4() and export it so that it is accessible by
handle_fragments() for conntrack packet reassembly.
Co-authored by: Justin Pettit <jpet...@ovn.org>
Signed-off-by: Greg Rose <gvrose8...@gmail.com>
Looks good to me.
Acked-by: Pravin B Shelar <pshe...@ovn.org>
Thanks,
Pravin.
Thanks Pravin.
I missed a dash in the Co-authored-by line. If that could be fixed up
on commit then good, otherwise I can resend.
- Greg
