Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-13 Thread Jes Sorensen
On 06/13/2017 01:49 PM, Saeed Mahameed wrote: On Mon, Jun 12, 2017 at 8:52 PM, Jes Sorensen wrote: On 06/07/2017 07:42 PM, Saeed Mahameed wrote: Multi-Physical Function Switch (MPFs) is required for when multi-PF configuration is enabled to allow passing user configured unicast MAC addresses

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-13 Thread Saeed Mahameed
On Mon, Jun 12, 2017 at 8:52 PM, Jes Sorensen wrote: > On 06/07/2017 07:42 PM, Saeed Mahameed wrote: >> >> Multi-Physical Function Switch (MPFs) is required for when multi-PF >> configuration is enabled to allow passing user configured unicast MAC >> addresses to the requesting PF. >> >> Before th

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-12 Thread Jes Sorensen
On 06/07/2017 07:42 PM, Saeed Mahameed wrote: Multi-Physical Function Switch (MPFs) is required for when multi-PF configuration is enabled to allow passing user configured unicast MAC addresses to the requesting PF. Before this patch eswitch.c used to manage the HW MPFS l2 table, eswitch always

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-08 Thread Or Gerlitz
On Thu, Jun 8, 2017 at 1:26 PM, Saeed Mahameed wrote: > On Thu, Jun 8, 2017 at 12:13 PM, Or Gerlitz wrote: >>> +int mlx5_mpfs_add_mac(struct mlx5_core_dev *dev, u8 *mac) >>> +{ >> >>> + if (!MLX5_VPORT_MANAGER(dev)) >>> + return 0; >>> + >>> + if (is_multicast_ether_ad

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-08 Thread Saeed Mahameed
On Thu, Jun 8, 2017 at 12:13 PM, Or Gerlitz wrote: > On Thu, Jun 8, 2017 at 2:42 AM, Saeed Mahameed wrote: > [...] >> 9 files changed, 376 insertions(+), 223 deletions(-) > > a bit of heavy duty for this sort of sensitive change, should > investigate if it can be broken a bit > yes, hence the R

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-08 Thread Or Gerlitz
On Thu, Jun 8, 2017 at 2:42 AM, Saeed Mahameed wrote: > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c > @@ -363,17 +364,28 @@ static void mlx5e_del_vlan_rules(struct mlx5e_priv > *priv) > static void mlx5e_execute_l2_action(struct

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-08 Thread Or Gerlitz
On Thu, Jun 8, 2017 at 2:42 AM, Saeed Mahameed wrote: [...] > 9 files changed, 376 insertions(+), 223 deletions(-) a bit of heavy duty for this sort of sensitive change, should investigate if it can be broken a bit > +int mlx5_mpfs_init(struct mlx5_core_dev *dev) > +{ > + int l2table_size

[PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-07 Thread Saeed Mahameed
Multi-Physical Function Switch (MPFs) is required for when multi-PF configuration is enabled to allow passing user configured unicast MAC addresses to the requesting PF. Before this patch eswitch.c used to manage the HW MPFS l2 table, eswitch always enabled vport(0) (NIC PF) vport's contexts updat