On Thu, Jun 8, 2017 at 1:26 PM, Saeed Mahameed
<sae...@dev.mellanox.co.il> wrote:
> On Thu, Jun 8, 2017 at 12:13 PM, Or Gerlitz <gerlitz...@gmail.com> wrote:
>>> +int mlx5_mpfs_add_mac(struct mlx5_core_dev *dev, u8 *mac)
>>> +{
>>
>>> + if (!MLX5_VPORT_MANAGER(dev))
>>> + return 0;
>>> +
>>> + if (is_multicast_ether_addr(mac))
>>> + return 0;
>> It would have been much better reviewed and maintained if we can code
>> things in a manner under which we don't get here if not appropriate and
>> not simulate successful return.
> Sure, will consider that, i just wanted to avoid ugly indentations in
> mlx5e set_rx_mode en_fs.c
I understand your concern re ugly indentations, but hopefully we can avoid them
