Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-28 Thread Daniel Santos
Hello Andrew, On 6/27/19 2:28 PM, Andrew Lunn wrote: >>> Looking at the data sheet page, you want FORCE_MODE_Pn set. You never >>> want the MAC directly talking to the PHY. Bad things will happen. >> So what exactly do you mean by the MAC directly talking to the PHY?  Do >> you mean setting speed,

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-27 Thread Andrew Lunn
> > Looking at the data sheet page, you want FORCE_MODE_Pn set. You never > > want the MAC directly talking to the PHY. Bad things will happen. > > So what exactly do you mean by the MAC directly talking to the PHY?  Do > you mean setting speed, duplex, etc. via the MAC registers instead of > via

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-27 Thread Daniel Santos
On 6/25/19 3:41 PM, Andrew Lunn wrote: > On Tue, Jun 25, 2019 at 02:27:55PM -0500, Daniel Santos wrote: >> On 6/25/19 2:02 PM, Andrew Lunn wrote: But will there still be a mechanism to ignore link partner's advertising and force these parameters? >>> >From man 1 ethtool: >>> >>>

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-26 Thread Russell King - ARM Linux admin
On Wed, Jun 26, 2019 at 11:46:15AM +0300, Vladimir Oltean wrote: > On Wed, 26 Jun 2019 at 10:42, Russell King - ARM Linux admin > wrote: > > > > On Wed, Jun 26, 2019 at 02:10:27AM +0300, Vladimir Oltean wrote: > > > On Wed, 26 Jun 2019 at 01:58, Russell King - ARM Linux admin > > > wrote: > > > >

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-26 Thread Vladimir Oltean
On Wed, 26 Jun 2019 at 10:42, Russell King - ARM Linux admin wrote: > > On Wed, Jun 26, 2019 at 02:10:27AM +0300, Vladimir Oltean wrote: > > On Wed, 26 Jun 2019 at 01:58, Russell King - ARM Linux admin > > wrote: > > > > > > On Wed, Jun 26, 2019 at 01:14:59AM +0300, Vladimir Oltean wrote: > > > >

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-26 Thread Russell King - ARM Linux admin
On Wed, Jun 26, 2019 at 02:10:27AM +0300, Vladimir Oltean wrote: > On Wed, 26 Jun 2019 at 01:58, Russell King - ARM Linux admin > wrote: > > > > On Wed, Jun 26, 2019 at 01:14:59AM +0300, Vladimir Oltean wrote: > > > On Wed, 26 Jun 2019 at 00:53, Russell King - ARM Linux admin > > > wrote: > > > >

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Andrew Lunn
On Wed, Jun 26, 2019 at 02:13:25AM +0300, Vladimir Oltean wrote: > On Wed, 26 Jun 2019 at 02:10, Vladimir Oltean wrote: > > > > On Wed, 26 Jun 2019 at 01:58, Russell King - ARM Linux admin > > wrote: > > > > > > On Wed, Jun 26, 2019 at 01:14:59AM +0300, Vladimir Oltean wrote: > > > > On Wed, 26 J

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Vladimir Oltean
On Wed, 26 Jun 2019 at 02:10, Vladimir Oltean wrote: > > On Wed, 26 Jun 2019 at 01:58, Russell King - ARM Linux admin > wrote: > > > > On Wed, Jun 26, 2019 at 01:14:59AM +0300, Vladimir Oltean wrote: > > > On Wed, 26 Jun 2019 at 00:53, Russell King - ARM Linux admin > > > wrote: > > > > > > > >

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Vladimir Oltean
On Wed, 26 Jun 2019 at 01:58, Russell King - ARM Linux admin wrote: > > On Wed, Jun 26, 2019 at 01:14:59AM +0300, Vladimir Oltean wrote: > > On Wed, 26 Jun 2019 at 00:53, Russell King - ARM Linux admin > > wrote: > > > > > > On Tue, Jun 25, 2019 at 11:24:01PM +0300, Vladimir Oltean wrote: > > > >

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Russell King - ARM Linux admin
On Wed, Jun 26, 2019 at 01:14:59AM +0300, Vladimir Oltean wrote: > On Wed, 26 Jun 2019 at 00:53, Russell King - ARM Linux admin > wrote: > > > > On Tue, Jun 25, 2019 at 11:24:01PM +0300, Vladimir Oltean wrote: > > > Hi Russell, > > > > > > On 6/24/19 6:39 PM, Russell King - ARM Linux admin wrote:

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Vladimir Oltean
On Wed, 26 Jun 2019 at 00:53, Russell King - ARM Linux admin wrote: > > On Tue, Jun 25, 2019 at 11:24:01PM +0300, Vladimir Oltean wrote: > > Hi Russell, > > > > On 6/24/19 6:39 PM, Russell King - ARM Linux admin wrote: > > > This should be removed - state->link is not for use in mac_config. > > >

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 11:24:01PM +0300, Vladimir Oltean wrote: > Hi Russell, > > On 6/24/19 6:39 PM, Russell King - ARM Linux admin wrote: > > This should be removed - state->link is not for use in mac_config. > > Even in fixed mode, the link can be brought up/down by means of a > > gpio, and th

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 10:41:48PM +0200, Andrew Lunn wrote: > On Tue, Jun 25, 2019 at 02:27:55PM -0500, Daniel Santos wrote: > > On 6/25/19 2:02 PM, Andrew Lunn wrote: > > >> But will there still be a mechanism to ignore link partner's advertising > > >> and force these parameters? > > > >From man

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 09:02:46PM +0200, Andrew Lunn wrote: > > But will there still be a mechanism to ignore link partner's advertising > > and force these parameters? > > From man 1 ethtool: > >-a --show-pause > Queries the specified Ethernet device for pause parameter >

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread René van Dorst
Quoting Andrew Lunn : Hi Andrew, On Tue, Jun 25, 2019 at 02:27:55PM -0500, Daniel Santos wrote: On 6/25/19 2:02 PM, Andrew Lunn wrote: >> But will there still be a mechanism to ignore link partner's advertising >> and force these parameters? > >From man 1 ethtool: > >-a --show-pause >

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Andrew Lunn
On Tue, Jun 25, 2019 at 02:27:55PM -0500, Daniel Santos wrote: > On 6/25/19 2:02 PM, Andrew Lunn wrote: > >> But will there still be a mechanism to ignore link partner's advertising > >> and force these parameters? > > >From man 1 ethtool: > > > >-a --show-pause > > Queries th

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Vladimir Oltean
Hi Russell, On 6/24/19 6:39 PM, Russell King - ARM Linux admin wrote: Hi, On Mon, Jun 24, 2019 at 04:52:47PM +0200, René van Dorst wrote: Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 237 +-- drivers/net/dsa

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Daniel Santos
On 6/25/19 2:02 PM, Andrew Lunn wrote: >> But will there still be a mechanism to ignore link partner's advertising >> and force these parameters? > >From man 1 ethtool: > >-a --show-pause > Queries the specified Ethernet device for pause parameter > information. > >-A

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Andrew Lunn
> But will there still be a mechanism to ignore link partner's advertising > and force these parameters? >From man 1 ethtool: -a --show-pause Queries the specified Ethernet device for pause parameter information. -A --pause Changes the pause parameters

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Daniel Santos
Hello, Although I'm new to the entire Ethernet / *MII subsystem and I haven't touched DSA yet, I've recently had to add some of this functionality to the older OpenWRT drivers for swconfig control over the ports.  René, do you have an actual datasheet or programming guide for the mt7530?  I only h

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 11:31:58AM +, René van Dorst wrote: > > > +if (state->link || mode == MLO_AN_FIXED) > > > +mcr |= PMCR_FORCE_LNK; > > > > This should be removed - state->link is not for use in mac_config. > > Even in fixed mode, the link can be brought u

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread René van Dorst
Quoting Daniel Santos : Hi Daniel, On 6/24/19 9:52 AM, René van Dorst wrote: Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 237 +-- drivers/net/dsa/mt7530.h | 9 ++ 2 files changed, 187 insertions(+), 59 dele

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread René van Dorst
Quoting Russell King - ARM Linux admin : Hi Russel, Thanks for your review, see also my comments and questions below. Hi, On Mon, Jun 24, 2019 at 04:52:47PM +0200, René van Dorst wrote: Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 237

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-24 Thread Daniel Santos
On 6/24/19 9:52 AM, René van Dorst wrote: > Convert mt7530 to PHYLINK API > > Signed-off-by: René van Dorst > --- > drivers/net/dsa/mt7530.c | 237 +-- > drivers/net/dsa/mt7530.h | 9 ++ > 2 files changed, 187 insertions(+), 59 deletions(-) > > diff --git

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-24 Thread Russell King - ARM Linux admin
Hi, On Mon, Jun 24, 2019 at 04:52:47PM +0200, René van Dorst wrote: > Convert mt7530 to PHYLINK API > > Signed-off-by: René van Dorst > --- > drivers/net/dsa/mt7530.c | 237 +-- > drivers/net/dsa/mt7530.h | 9 ++ > 2 files changed, 187 insertions(+), 59 del

[PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-24 Thread René van Dorst
Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 237 +-- drivers/net/dsa/mt7530.h | 9 ++ 2 files changed, 187 insertions(+), 59 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 3