Re: [PATCH RFC net-next] net: mtk_eth_soc: use resolved link config for PCS PHY

2020-06-30 Thread Russell King - ARM Linux admin
On Tue, Jun 30, 2020 at 10:13:08PM +, René van Dorst wrote: > Hi Russel and Sean, > > Quoting Russell King - ARM Linux admin : > > > On Tue, Jun 30, 2020 at 11:15:42AM +0100, Russell King wrote: > > > The SGMII PCS PHY needs to be updated with the link configuration in > > > the mac_link_up()

Re: [PATCH RFC net-next] net: mtk_eth_soc: use resolved link config for PCS PHY

2020-06-30 Thread René van Dorst
Hi Russel and Sean, Quoting Russell King - ARM Linux admin : On Tue, Jun 30, 2020 at 11:15:42AM +0100, Russell King wrote: The SGMII PCS PHY needs to be updated with the link configuration in the mac_link_up() call rather than in mac_config(). However, mtk_sgmii_setup_mode_force() programs th

Re: [PATCH RFC net-next] net: mtk_eth_soc: use resolved link config for PCS PHY

2020-06-30 Thread Russell King - ARM Linux admin
On Tue, Jun 30, 2020 at 11:15:42AM +0100, Russell King wrote: > The SGMII PCS PHY needs to be updated with the link configuration in > the mac_link_up() call rather than in mac_config(). However, > mtk_sgmii_setup_mode_force() programs the SGMII block during > mac_config() when using 802.3z interf

[PATCH RFC net-next] net: mtk_eth_soc: use resolved link config for PCS PHY

2020-06-30 Thread Russell King
The SGMII PCS PHY needs to be updated with the link configuration in the mac_link_up() call rather than in mac_config(). However, mtk_sgmii_setup_mode_force() programs the SGMII block during mac_config() when using 802.3z interface modes with the link configuration. Split that functionality from