Re: [PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread David Miller
From: Stephen Hemminger Date: Fri, 6 Oct 2017 16:12:45 -0700 > On Fri, 6 Oct 2017 18:37:01 -0400 > Willem de Bruijn wrote: > >> > It looks like you are just exporting the statistics taht are already >> > through normal path. The purpose of ethtool stats is to provide >> > statistics unique to t

Re: [PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread Stephen Hemminger
On Fri, 6 Oct 2017 18:37:01 -0400 Willem de Bruijn wrote: > > It looks like you are just exporting the statistics taht are already > > through normal path. The purpose of ethtool stats is to provide > > statistics unique to the device, not to repeat what is available throug > > ip, ifconfig, etc.

Re: [PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread Willem de Bruijn
On Fri, Oct 6, 2017 at 6:30 PM, Stephen Hemminger wrote: > On Fri, 6 Oct 2017 18:25:14 -0400 > Willem de Bruijn wrote: > >> From: Willem de Bruijn >> >> Support ethtool -S on tun devices. This interface allows exporting >> device-specific stats not present in rtnl stats. >> >> Signed-off-by: Wi

Re: [PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread Stephen Hemminger
On Fri, 6 Oct 2017 18:25:14 -0400 Willem de Bruijn wrote: > From: Willem de Bruijn > > Support ethtool -S on tun devices. This interface allows exporting > device-specific stats not present in rtnl stats. > > Signed-off-by: Willem de Bruijn > --- > drivers/net/tun.c | 38 +++

[PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread Willem de Bruijn
From: Willem de Bruijn Support ethtool -S on tun devices. This interface allows exporting device-specific stats not present in rtnl stats. Signed-off-by: Willem de Bruijn --- drivers/net/tun.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/n