From: Stephen Hemminger <step...@networkplumber.org> Date: Fri, 6 Oct 2017 16:12:45 -0700
> On Fri, 6 Oct 2017 18:37:01 -0400 > Willem de Bruijn <willemdebruijn.ker...@gmail.com> wrote: > >> > It looks like you are just exporting the statistics taht are already >> > through normal path. The purpose of ethtool stats is to provide >> > statistics unique to the device, not to repeat what is available throug >> > ip, ifconfig, etc. >> >> A follow-up patch adds non-standard statistics. >> >> I included these common ones, because the new zerocopy counters >> are only interesting in relation to tx_packets. >> >> It also seems customary among existing network drivers to include >> at least these base counters in the ethtool output. > > Only some drivers that slipped through before I started noticing. > Do Not Repeat. Agreed, that is a bad practice unless it is being done to export per-queue versions of those standard netdev statistics.