Re: [Bonding-devel] Re: [PATCH RESEND] bonding: allow bond to use TSO if slaves support it

2006-01-30 Thread Jay Vosburgh
Add NETIF_F_TSO (NETIF_F_UFO) to BOND_INTERSECT_FEATURES so that it can be used by a bonding device iff all its slave devices support TSO (UFO). Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> diff --git a/drivers/net/bonding/bond_main.c b/driver

Re: [Bonding-devel] Re: [PATCH RESEND] bonding: allow bond to use TSO if slaves support it

2006-01-30 Thread Arthur Kepner
On Mon, 30 Jan 2006, Jay Vosburgh wrote: > > In looking at it, I think the conditions will be the same for > NETIF_F_UFO; can you add it to the mix the same way as TSO? > Yes. > ... > I think a comment noting that we don't need to check is > sufficient. > How does the followin

Re: [Bonding-devel] Re: [PATCH RESEND] bonding: allow bond to use TSO if slaves support it

2006-01-30 Thread Jay Vosburgh
Arthur Kepner <[EMAIL PROTECTED]> wrote: [...] >But if each slave device supports TSO, then each slave device >also must support SG, and therefore the bond device will support >SG too, right? Hmm. Good point. I pondered this, and I think this is true for slave adds and removes, and ethto

Re: [Bonding-devel] Re: [PATCH RESEND] bonding: allow bond to use TSO if slaves support it

2006-01-30 Thread Arthur Kepner
On Mon, 30 Jan 2006, Jay Vosburgh wrote: > > I believe that bond_compute_features() also needs logic to > disable NETIF_F_TSO if NETIF_F_SG is not set. > But if each slave device supports TSO, then each slave device also must support SG, and therefore the bond device will support SG

Re: [PATCH RESEND] bonding: allow bond to use TSO if slaves support it

2006-01-30 Thread Jay Vosburgh
Arthur Kepner <[EMAIL PROTECTED]> wrote: >Add NETIF_F_TSO to BOND_INTERSECT_FEATURES so that it can be >used by a bonding device iff all its slave devices support TSO. I believe that bond_compute_features() also needs logic to disable NETIF_F_TSO if NETIF_F_SG is not set. -J ---

[PATCH RESEND] bonding: allow bond to use TSO if slaves support it

2006-01-30 Thread Arthur Kepner
Add NETIF_F_TSO to BOND_INTERSECT_FEATURES so that it can be used by a bonding device iff all its slave devices support TSO. Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> -- Arthurdiff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c --- a/drivers/net/bonding/bond_ma