Arthur Kepner <[EMAIL PROTECTED]> wrote:
[...]
>But if each slave device supports TSO, then each slave device
>also must support SG, and therefore the bond device will support
>SG too, right?
Hmm. Good point. I pondered this, and I think this is true for
slave adds and removes, and ethtool looks to clear TSO if SG is cleared,
so I'm not seeing any way around it.
In looking at it, I think the conditions will be the same for
NETIF_F_UFO; can you add it to the mix the same way as TSO?
>In any case, I don't object to adding this check to
>bond_compute_features(). It would be consistent with other
>driver code, and perhaps more clear.
I think a comment noting that we don't need to check is
sufficient.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
