Re: [PATCH 4/6] net: make skb_gso_*_seglen functions private

2018-02-28 Thread David Miller
From: Daniel Axtens Date: Wed, 28 Feb 2018 00:04:05 +1100 > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index 0c0c1d6f28ef..a664a3ae507e 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -4893,7 +4893,7 @@ EXPORT_SYMBOL_GPL(skb_scrub_packet); > * > * The MAC/L2 or netwo

[PATCH 4/6] net: make skb_gso_*_seglen functions private

2018-02-27 Thread Daniel Axtens
They're very hard to use properly as they do not consider the GSO_BY_FRAGS case. Code should use skb_gso_validate_network_len and skb_gso_validate_mac_len as they do consider this case. Make the seglen functions static inline, which stops people using them, and also means the validate functions do