From: Daniel Axtens <d...@axtens.net>
Date: Wed, 28 Feb 2018 00:04:05 +1100

> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 0c0c1d6f28ef..a664a3ae507e 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -4893,7 +4893,7 @@ EXPORT_SYMBOL_GPL(skb_scrub_packet);
>   *
>   * The MAC/L2 or network (IP, IPv6) headers are not accounted for.
>   */
> -unsigned int skb_gso_transport_seglen(const struct sk_buff *skb)
> +static inline unsigned int skb_gso_transport_seglen(const struct sk_buff 
> *skb)
 ...
> +static inline unsigned int skb_gso_network_seglen(const struct sk_buff *skb)
 ...
> +static inline unsigned int skb_gso_mac_seglen(const struct sk_buff *skb)

Please drop the inline keyword.  Functions in foo.c files should not be
marked inline, let the compiler decide whether it's beneficial to
inline or not.

Reply via email to