From: Florian Zumbiehl <[EMAIL PROTECTED]>
Date: Sat, 21 Apr 2007 01:44:05 +0200
> > This patch doesn't apply becuase in the actual pppoe.c code:
>
> [...]
>
> > So I'm having trouble figuring out what tree you generated
> > that patch against :-) Perhaps there was an earlier patch
> > I missed
Hi,
> This patch doesn't apply becuase in the actual pppoe.c code:
[...]
> So I'm having trouble figuring out what tree you generated
> that patch against :-) Perhaps there was an earlier patch
> I missed or something.
>
> But I won't second guess and leave it to you to let me know
> what I sh
From: Michal Ostrowski <[EMAIL PROTECTED]>
Date: Sun, 11 Mar 2007 21:36:56 -0500
> Attached below is my take on how to address this problem.
> This addresses any concerns you may have had about checking
> po->pppoe_dev==NULL,
> because accesses to this field are now synchronized with pppoe_hash
Hi,
> Attached below is my take on how to address this problem.
> This addresses any concerns you may have had about checking
> po->pppoe_dev==NULL,
> because accesses to this field are now synchronized with pppoe_hash_lock.
That indeed looks like a much cleaner solution, so I'd certainly pref
Attached below is my take on how to address this problem.
This addresses any concerns you may have had about checking po->pppoe_dev==NULL,
because accesses to this field are now synchronized with pppoe_hash_lock.
Once we can settle on a fix for this, I'll deal with the SID==0 issue
(trying to d
I need some more time to think about this one; there are some problem
I'm seeing here but I can't look at it right now. I'll send out my
version of a patch for this tomorrow and we can discuss more.
Regarding the previous three patches, they seem fine after a first pass.
However, I'd like to ask
Hi,
below you find the last patch for now. It (hopefully) fixes a race
between a socket being release()d and the interface it's using going
down. As pppoe_release() didn't lock the socket, and pppoe_flush_dev()
did the locking in the wrong place, pppoe_flush_dev() could set
po->pppoe_dev to NULL,
