Re: [PATCH 3/3] [NET_DOC] Document some simple rules for actions

2007-10-26 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Sun, 21 Oct 2007 15:22:17 -0400 > Against net-2.6 Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] [NET_DOC] Document some simple rules for actions

2007-10-21 Thread jamal
Against net-2.6 cheers, jamal 0003-NET_DOC-Document-some-simple-rules-for-actions.txt Description: application/mbox

Re: [PATCH 3/3] [NET_DOC] Document some simple rules for actions

2007-10-16 Thread jamal
On Tue, 2007-16-10 at 20:51 +0800, Herbert Xu wrote: > But I still think the distinction between skb_clone and > skb_copy_header is wrong. > > When you munge a packet, it's still going to go back up > the stack and be processed along the same path. Therefore > you should be calling pskb_expand_h

Re: [PATCH 3/3] [NET_DOC] Document some simple rules for actions

2007-10-16 Thread Herbert Xu
On Tue, Oct 16, 2007 at 08:33:31AM -0400, jamal wrote: > > +2) If you munge any packet thou shalt call skb_expand in the case > +someone else is referencing the skb. After that you "own" the skb. > +You must also tell us if it is ok to munge the packet (TC_OK2MUNGE), > +this way any action downst

[PATCH 3/3] [NET_DOC] Document some simple rules for actions

2007-10-16 Thread jamal
cheers, jamal [NET_DOC] Document some simple rules for actions This patch adds documentation on what is expected of an action which branches away from the action-graph or when it needs to trample on actins. It also describes what is expected of users of such actions. Signed-off-by: Jamal Hadi Sa