On Tue, Oct 16, 2007 at 08:33:31AM -0400, jamal wrote: > > +2) If you munge any packet thou shalt call skb_expand in the case > +someone else is referencing the skb. After that you "own" the skb. > +You must also tell us if it is ok to munge the packet (TC_OK2MUNGE), > +this way any action downstream can stomp on the packet.
Thanks for the documentation! But I still think the distinction between skb_clone and skb_copy_header is wrong. When you munge a packet, it's still going to go back up the stack and be processed along the same path. Therefore you should be calling pskb_expand_head. In other words, this does not explain why skb_copy/pskb_copy and skb_copy_expand should differ from skb_clone. As far as I can see all these functions should behave in the same manner with respect to tc_verd. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
