From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 08 Nov 2005 12:21:38 +1100
> [IPV4] Fix ip_queue_xmit identity increment for TSO packets
>
> When ip_queue_xmit calls ip_select_ident_more for IP identity selection
> it gives it the wrong packet count for TSO packets. The ip_select_*
> functions e
Tom Young <[EMAIL PROTECTED]> wrote:
>
> Thanks for clearing that up, I see that I was being too TCP-centric now
> in my see if I broke anything testing. My patch solves my immediate
> needs, but I will revisit this later and attempt a more generic solution
> if time permits.
How about something
On Mon, 2005-11-07 at 16:16 -0800, David S. Miller wrote:
> TCP ends up setting it to 1 but other protocols do not.
>
> But other protocols use ip_queue_xmit() as well, such as DCCP
> and SCTP, and they won't change it from it's alloc_skb() time
> value of "0".
Thanks for clearing that up, I see
From: Tom Young <[EMAIL PROTECTED]>
Date: Tue, 08 Nov 2005 10:33:50 +1100
> I'm not convinced that is true, I don't have a TSO supported card and I
> get tso_segs to be 1 inside the ip_queue_xmit function.
> Looking through tcp_output.c, all references I could find expected
> tso_segs to be a coun
On Mon, 2005-11-07 at 10:01 -0800, David S. Miller wrote:
> From: Tom Young <[EMAIL PROTECTED]>
> Date: Mon, 07 Nov 2005 15:59:49 +1100
>
> > The socket ip id currently gets incremented by 1 + the number of
> > segments leading to an increment of 2 in the standard non-TSO case.
> > This patch fixe
From: Tom Young <[EMAIL PROTECTED]>
Date: Mon, 07 Nov 2005 15:59:49 +1100
> The socket ip id currently gets incremented by 1 + the number of
> segments leading to an increment of 2 in the standard non-TSO case.
> This patch fixes 'more' to be a count of extra segments.
>
> Signed-off-by: Thomas Y
I'm resubmitting this as I think while its effect is minimal in most
cases, it does still fix a bug. The current implemenation effectly halfs
the ip id space because of the off by one error. This could lead to
problems on LFNs.
The socket ip id currently gets incremented by 1 + the number of
seg
