On Mon, 2005-11-07 at 10:01 -0800, David S. Miller wrote: > From: Tom Young <[EMAIL PROTECTED]> > Date: Mon, 07 Nov 2005 15:59:49 +1100 > > > The socket ip id currently gets incremented by 1 + the number of > > segments leading to an increment of 2 in the standard non-TSO case. > > This patch fixes 'more' to be a count of extra segments. > > > > Signed-off-by: Thomas Young <[EMAIL PROTECTED]> > > The tso_segs field is zero for non-TSO frames, so your patch breaks > non-TSO frames whilst fixing TSO ones :-) > -
I'm not convinced that is true, I don't have a TSO supported card and I get tso_segs to be 1 inside the ip_queue_xmit function. Looking through tcp_output.c, all references I could find expected tso_segs to be a count of segments to send seemingly regardless of whether TSO was in use. My patch certainly fixes the non-TSO case for my setup, unfortunatly I lack a TSO supported card to test the TSO case. If you agree that this is worth changing, then I think it would be better to attack all the _more functions to remove the 1 + and rename the "more" part to something more appropriate. Tom - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
