On Wed, Mar 08, 2006 at 12:59:14PM +, Christoph Hellwig wrote:
> > + if (unlikely(status->frame_size > skb_tailroom(packet->skb) -
> > sizeof(struct ipw_rt_hdr))) {
>
> please don't spill over 80 characters.
>
> > #include
> >
> > +#ifdef CONFIG_IPW2100_MONITOR
> > +#include
> > +#end
Christoph Hellwig wrote:
>> #include
>>
>>+#ifdef CONFIG_IPW2100_MONITOR
>>+#include
>>+#endif
>>
>>
>
>please include the header unconditionally.
>
>
As it is only conditionally used, what is the reasoning for including
what isn't needed? I'm not opposed to removing the conditional, bu
> + if (unlikely(status->frame_size > skb_tailroom(packet->skb) -
> sizeof(struct ipw_rt_hdr))) {
please don't spill over 80 characters.
> #include
>
> +#ifdef CONFIG_IPW2100_MONITOR
> +#include
> +#endif
please include the header unconditionally.
> +
> #include
and for a followon
From: Stefan Rompf <[EMAIL PROTECTED]>
Date: Tue, 21 Feb 2006 18:36:17 + (+0800)
[PATCH 2/6] ipw2100: add radiotap headers to packtes captured in monitor mode
Signed-off-by: Stefan Rompf <[EMAIL PROTECTED]>
Signed-off-by: Andrea Merello
Signed-off-by: Zhu Yi <[EMAIL PROTECT
