Christoph Hellwig wrote: >> #include <net/ieee80211.h> >> >>+#ifdef CONFIG_IPW2100_MONITOR >>+#include <net/ieee80211_radiotap.h> >>+#endif >> >> > >please include the header unconditionally. > > As it is only conditionally used, what is the reasoning for including what isn't needed? I'm not opposed to removing the conditional, but I would like to understand the motivation.
>>+ >> #include <linux/workqueue.h> >> >> > >and for a followon patch please inlcude <net/*.h> after <linux/*.h> > > Is this to resolve potential future dependency ordering or style or ? If it is purely stylistic, it might be good to have Documentation/CodingStyle define #include clustering and the preferred order (since the order and clustering appears to be more or less random throughout the rest of the kernel in regard to <net/*>, <linux/*>, and <asm/*> usage) And if it is due to potential future dependency ordering issues, a discussion of that in CodingStyle could be useful as well. James - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
