Re: [PATCH 2/3] net: macb: Fix more coding style issues

2016-03-07 Thread Moritz Fischer
Hi Joe, David, On Mon, Mar 7, 2016 at 10:49 AM, David Miller wrote: > From: Moritz Fischer > Date: Mon, 7 Mar 2016 08:17:38 -0800 > >> @@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int >> first_frag, >> static int macb_rx(struct macb *bp, int budget) >> { >> in

Re: [PATCH 2/3] net: macb: Fix more coding style issues

2016-03-07 Thread David Miller
From: Moritz Fischer Date: Mon, 7 Mar 2016 08:17:38 -0800 > @@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int > first_frag, > static int macb_rx(struct macb *bp, int budget) > { > int received = 0; > + int dropped; > unsigned int tail; > int firs

Re: [PATCH 2/3] net: macb: Fix more coding style issues

2016-03-07 Thread Joe Perches
On Mon, 2016-03-07 at 08:17 -0800, Moritz Fischer wrote: > This commit takes care of the coding style warnings > that are mostly due to a different comment style and > lines over 80 chars. [] > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c [] > @@ -127,8

[PATCH 2/3] net: macb: Fix more coding style issues

2016-03-07 Thread Moritz Fischer
This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars. Notable exceptions are ether_addr_copy vs memcpy, as well as a dangling else after a return. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 109 +