On Mon, 2016-03-07 at 08:17 -0800, Moritz Fischer wrote: > This commit takes care of the coding style warnings > that are mostly due to a different comment style and > lines over 80 chars. [] > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c [] > @@ -127,8 +126,7 @@ static void hw_writel(struct macb *bp, int offset, u32 > value) > writel_relaxed(value, bp->regs + offset); > } > > -/* > - * Find the CPU endianness by using the loopback bit of NCR register. When > the > +/* Find the CPU endianness by using the loopback bit of NCR register. When > the > * CPU is in big endian we need to program swaped mode for management
swaped/swapped typo @@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int first_frag, > static int macb_rx(struct macb *bp, int budget) > { > int received = 0; > + int dropped; This is an unnecessary and unmentioned change. > unsigned int tail; > int first_frag = -1; > > @@ -968,7 +967,6 @@ static int macb_rx(struct macb *bp, int budget) > } > > if (ctrl & MACB_BIT(RX_EOF)) { > - int dropped; > BUG_ON(first_frag == -1); > > dropped = macb_rx_frame(bp, first_frag, tail); >