Re: [PATCH 2/3] net: fec: convert to using gpiod framework

2015-12-01 Thread Lothar Waßmann
uer; Stefan Agner; linux- > > ker...@vger.kernel.org; netdev@vger.kernel.org; Jeff Kirsher; Uwe Kleine- > > König > > Subject: [PATCH 2/3] net: fec: convert to using gpiod framework > > > > Use gpiod_get_optional() instead of checking for a valid GPIO number

RE: [PATCH 2/3] net: fec: convert to using gpiod framework

2015-11-30 Thread Duan Andy
ux- > ker...@vger.kernel.org; netdev@vger.kernel.org; Jeff Kirsher; Uwe Kleine- > König > Subject: [PATCH 2/3] net: fec: convert to using gpiod framework > > Use gpiod_get_optional() instead of checking for a valid GPIO number and > calling devm_gpio_request_one() conditionally. > &

Re: [PATCH 2/3] net: fec: convert to using gpiod framework

2015-11-30 Thread Fabio Estevam
On Mon, Nov 30, 2015 at 9:32 AM, Lothar Waßmann wrote: > - gpio_set_value_cansleep(phy_reset, 1); > + gpiod_set_value_cansleep(phy_reset, 1); This will break some existing DTBs. Currently the fec driver does not care whether 'phy-reset-gpios' is active low or active high. (Yes, it

[PATCH 2/3] net: fec: convert to using gpiod framework

2015-11-30 Thread Lothar Waßmann
Use gpiod_get_optional() instead of checking for a valid GPIO number and calling devm_gpio_request_one() conditionally. Signed-off-by: Lothar Waßmann --- drivers/net/ethernet/freescale/fec_main.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/net/e