Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-15 Thread Igor Russkikh
>>> - aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &aqc111_data->phy_cfg); >>> + phy_on_the_wire = aqc111_data->phy_cfg; >>> + aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &phy_on_the_wire); >> >> Hi Oliver, >> >> I see all write32_cmd and write16_cmd are using a temporary variable to do an >> int

Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-14 Thread Oliver Neukum
On Di, 2019-05-14 at 12:11 +, Igor Russkikh wrote: > On 09.05.2019 12:08, Oliver Neukum wrote: > > When writing to the phy on BE architectures an internal data structure > > was directly given, leading to it being byte swapped in the wrong > > way for the CPU in 50% of all cases. A temporary bu

Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-14 Thread Igor Russkikh
On 09.05.2019 12:08, Oliver Neukum wrote: > When writing to the phy on BE architectures an internal data structure > was directly given, leading to it being byte swapped in the wrong > way for the CPU in 50% of all cases. A temporary buffer must be used. > > Signed-off-by: Oliver Neukum > --- >

Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-09 Thread David Miller
From: Oliver Neukum Date: Thu, 9 May 2019 11:08:17 +0200 > When writing to the phy on BE architectures an internal data structure > was directly given, leading to it being byte swapped in the wrong > way for the CPU in 50% of all cases. A temporary buffer must be used. > > Signed-off-by: Oliver

[PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-09 Thread Oliver Neukum
When writing to the phy on BE architectures an internal data structure was directly given, leading to it being byte swapped in the wrong way for the CPU in 50% of all cases. A temporary buffer must be used. Signed-off-by: Oliver Neukum --- drivers/net/usb/aqc111.c | 23 +-- 1