Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-27 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: CRC stripping is breaking SMBUS-connected BMC's. We disable this feature to make it work. This fixes related bugs regarding SOL. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-26 Thread Jeff Garzik
Kok, Auke wrote: CRC stripping is breaking SMBUS-connected BMC's. We disable this feature to make it work. This fixes related bugs regarding SOL. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |7 ++- 1

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Jesse Brandeburg
On 6/22/06, Ben Greear <[EMAIL PROTECTED]> wrote: Jesse Brandeburg wrote: > On 6/21/06, Ben Greear <[EMAIL PROTECTED]> wrote: > >> Kok, Auke wrote: >> > CRC stripping is breaking SMBUS-connected BMC's. We disable this >> > feature to make it work. This fixes related bugs regarding SOL. >> >> Shou

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Lennert Buytenhek
On Thu, Jun 22, 2006 at 08:39:10AM -0700, Jesse Brandeburg wrote: > >> CRC stripping is breaking SMBUS-connected BMC's. We disable this > >> feature to make it work. This fixes related bugs regarding SOL. > > > >Shouldn't you also have to subtract 4 bytes when setting the skb len > >in the receive

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Ben Greear
Jesse Brandeburg wrote: On 6/21/06, Ben Greear <[EMAIL PROTECTED]> wrote: Kok, Auke wrote: > CRC stripping is breaking SMBUS-connected BMC's. We disable this > feature to make it work. This fixes related bugs regarding SOL. Shouldn't you also have to subtract 4 bytes when setting the skb len i

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Auke Kok
Ben Greear wrote: Kok, Auke wrote: CRC stripping is breaking SMBUS-connected BMC's. We disable this feature to make it work. This fixes related bugs regarding SOL. Shouldn't you also have to subtract 4 bytes when setting the skb len in the receive logic? Perhaps when setting the rx-bytes coun

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-22 Thread Jesse Brandeburg
On 6/21/06, Ben Greear <[EMAIL PROTECTED]> wrote: Kok, Auke wrote: > CRC stripping is breaking SMBUS-connected BMC's. We disable this > feature to make it work. This fixes related bugs regarding SOL. Shouldn't you also have to subtract 4 bytes when setting the skb len in the receive logic? Perh

Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-21 Thread Ben Greear
Kok, Auke wrote: CRC stripping is breaking SMBUS-connected BMC's. We disable this feature to make it work. This fixes related bugs regarding SOL. Shouldn't you also have to subtract 4 bytes when setting the skb len in the receive logic? Perhaps when setting the rx-bytes counter as well? Ben

[PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-21 Thread Kok, Auke
CRC stripping is breaking SMBUS-connected BMC's. We disable this feature to make it work. This fixes related bugs regarding SOL. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |7 ++- 1 files changed, 6