On Thu, Jun 22, 2006 at 08:39:10AM -0700, Jesse Brandeburg wrote: > >> CRC stripping is breaking SMBUS-connected BMC's. We disable this > >> feature to make it work. This fixes related bugs regarding SOL. > > > >Shouldn't you also have to subtract 4 bytes when setting the skb len > >in the receive logic? Perhaps when setting the rx-bytes counter as well? > > we thought about this, but most drivers don't strip the CRC,
Really? > and we couldn't find any tests including bridging that cared if the > CRC was there in the indicated packet. Bridging definitely cares -- some years ago there was a case where 8139too NICs would pass packets up the stack with 4 bytes of FCS, and that causes frames received on 8139too interfaces not to be forwarded to other interfaces because on TX, the frame would be too long. Maybe e1000 is okay with sending oversized frames, but other NIC drivers might not be. (Did you test without bridge-netfilter enabled? bridge-nf might trim incoming IP packets even in the bridging case.) cheers, Lennert - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
