Re: [PATCH 1/4] tg3: Fix nvram arbitration

2005-12-13 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 13 Dec 2005 15:15:35 -0800 > Yes. But add the following as well: > > --- a/drivers/net/tg3.c 2005-12-13 14:28:05.0 -0800 > +++ b/drivers/net/tg3.c 2005-12-13 14:27:31.0 -0800 > @@ -9909,9 +9909,11 @@ static int __devi

Re: [PATCH 1/4] tg3: Fix nvram arbitration

2005-12-13 Thread Michael Chan
On Tue, 2005-12-13 at 16:10 -0800, David S. Miller wrote: > Like this? > > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c > index be1f30a..eadc0c3 100644 > --- a/drivers/net/tg3.c > +++ b/drivers/net/tg3.c > @@ -4368,6 +4368,9 @@ static int tg3_chip_reset(struct tg3 *tp > > udelay(120

Re: [PATCH 1/4] tg3: Fix nvram arbitration

2005-12-13 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 13 Dec 2005 14:19:40 -0800 > Yes, your patch looks cleaner but will require additional changes. > Sometimes, we get the lock just before chip reset and we don't release > it because the reset automatically releases it. We'll have to reset the > l

Re: [PATCH 1/4] tg3: Fix nvram arbitration

2005-12-13 Thread Michael Chan
On Tue, 2005-12-13 at 15:45 -0800, David S. Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Tue, 13 Dec 2005 13:37:25 -0800 > > > Fix nvram arbitration bugs. The nvram arbitration rules were not > > strictly followed in a few places and this could lead to reading > > corrupted val

Re: [PATCH 1/4] tg3: Fix nvram arbitration

2005-12-13 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 13 Dec 2005 13:37:25 -0800 > Fix nvram arbitration bugs. The nvram arbitration rules were not > strictly followed in a few places and this could lead to reading > corrupted values from the nvram. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED

[PATCH 1/4] tg3: Fix nvram arbitration

2005-12-13 Thread Michael Chan
Fix nvram arbitration bugs. The nvram arbitration rules were not strictly followed in a few places and this could lead to reading corrupted values from the nvram. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 47bd4a3..dabc39b 100644 ---