David Miller wrote:
> From: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Wed, 18 Jul 2007 12:01:38 +0200
>
>
>>rae l wrote:
>>
>>>All in one word, I don't think the single file dev_mcast.c is needed
>>>anymore.
>>
>>Agreed. But dev.c is growing larger and larger, maybe dev_addr.c?
>>Or dev_config.
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 18 Jul 2007 12:01:38 +0200
> rae l wrote:
> > All in one word, I don't think the single file dev_mcast.c is needed
> > anymore.
>
> Agreed. But dev.c is growing larger and larger, maybe dev_addr.c?
> Or dev_config.c, with some of the other devi
From: "rae l" <[EMAIL PROTECTED]>
Date: Wed, 18 Jul 2007 17:59:52 +0800
> And then the dev_mcast.c is now only 256 lines long(versus dev.c 4052 lines),
> just left a few multicast related functions definition and "dev_mcast"
> procfs code,
> I have an idea to merge all code dev_mcast.c into dev.c,
rae l wrote:
> All in one word, I don't think the single file dev_mcast.c is needed
> anymore.
Agreed. But dev.c is growing larger and larger, maybe dev_addr.c?
Or dev_config.c, with some of the other device configuration functions?
-
To unsubscribe from this list: send the line "unsubscribe netd
On 7/18/07, David Miller <[EMAIL PROTECTED]> wrote:
From: Denis Cheng <[EMAIL PROTECTED]>
Date: Wed, 18 Jul 2007 10:41:03 +0800
> Because this function is only called by unregister_netdevice,
> this moving could make this non-global function static,
> and also remove its declaration in netdevice
From: Denis Cheng <[EMAIL PROTECTED]>
Date: Wed, 18 Jul 2007 10:41:03 +0800
> Because this function is only called by unregister_netdevice,
> this moving could make this non-global function static,
> and also remove its declaration in netdevice.h;
>
> Any further, function __dev_addr_discard is a
Because this function is only called by unregister_netdevice,
this moving could make this non-global function static,
and also remove its declaration in netdevice.h;
Any further, function __dev_addr_discard is also just called by
dev_mc_discard and dev_unicast_discard, keeping this two functions
b
