From: Denis Cheng <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 10:41:03 +0800
> Because this function is only called by unregister_netdevice, > this moving could make this non-global function static, > and also remove its declaration in netdevice.h; > > Any further, function __dev_addr_discard is also just called by > dev_mc_discard and dev_unicast_discard, keeping this two functions > both in one c file could make __dev_addr_discard also static > and remove its declaration in netdevice.h; > > Futhermore, the sequential call to dev_unicast_discard and then > dev_mc_discard in unregister_netdevice have a similar mechanism that: > (netif_tx_lock_bh / __dev_addr_discard / netif_tx_unlock_bh), > they should merged into one to eliminate duplicates in acquiring and > releasing the dev->_xmit_lock, this would be done in my following patch. > > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Patch applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
