Re: [PATCH 1/2] spi: Micrel eth switch: declare missing of table

2019-04-25 Thread Mark Brown
On Tue, Apr 23, 2019 at 07:33:10PM +0200, Heiner Kallweit wrote: > Except having "switch" in the name this driver is solely a SPI driver > and it uses no network code at all. And it has no dependency on any > network driver. Therefore I wouldn't consider it a network driver. > Else any functionali

Re: [PATCH 1/2] spi: Micrel eth switch: declare missing of table

2019-04-23 Thread David Miller
From: Daniel Gomez Date: Mon, 22 Apr 2019 21:08:03 +0200 > Add missing table for SPI driver relying on SPI > device match since compatible is in a DT binding or in a DTS. > > Before this patch: > modinfo drivers/net/phy/spi_ks8995.ko | grep alias > alias: spi:ksz8795 > alias:

Re: [PATCH 1/2] spi: Micrel eth switch: declare missing of table

2019-04-23 Thread Heiner Kallweit
On 23.04.2019 14:28, Andrew Lunn wrote: >> I wonder why this SPI driver is under drivers/net/phy. Just because >> the SPI IP is found on an ethernet switch chip? And even then it >> would be wrong, I see no link to a PHY at all. I'd say the driver >> belongs to drivers/spi. Shouldn't we move it? >

Re: [PATCH 1/2] spi: Micrel eth switch: declare missing of table

2019-04-23 Thread Andrew Lunn
> I wonder why this SPI driver is under drivers/net/phy. Just because > the SPI IP is found on an ethernet switch chip? And even then it > would be wrong, I see no link to a PHY at all. I'd say the driver > belongs to drivers/spi. Shouldn't we move it? This driver is old. It is probably from befor

Re: [PATCH 1/2] spi: Micrel eth switch: declare missing of table

2019-04-22 Thread Heiner Kallweit
On 22.04.2019 21:08, Daniel Gomez wrote: > Add missing table for SPI driver relying on SPI > device match since compatible is in a DT binding or in a DTS. > > Before this patch: > modinfo drivers/net/phy/spi_ks8995.ko | grep alias > alias: spi:ksz8795 > alias: spi:ksz8864 > alia

[PATCH 1/2] spi: Micrel eth switch: declare missing of table

2019-04-22 Thread Daniel Gomez
Add missing table for SPI driver relying on SPI device match since compatible is in a DT binding or in a DTS. Before this patch: modinfo drivers/net/phy/spi_ks8995.ko | grep alias alias: spi:ksz8795 alias: spi:ksz8864 alias: spi:ks8995 After this patch: modinfo drivers