On 22.04.2019 21:08, Daniel Gomez wrote:
> Add missing <of_device_id> table for SPI driver relying on SPI
> device match since compatible is in a DT binding or in a DTS.
>
> Before this patch:
> modinfo drivers/net/phy/spi_ks8995.ko | grep alias
> alias: spi:ksz8795
> alias: spi:ksz8864
> alias: spi:ks8995
>
> After this patch:
> modinfo drivers/net/phy/spi_ks8995.ko | grep alias
> alias: spi:ksz8795
> alias: spi:ksz8864
> alias: spi:ks8995
> alias: of:N*T*Cmicrel,ksz8795C*
> alias: of:N*T*Cmicrel,ksz8795
> alias: of:N*T*Cmicrel,ksz8864C*
> alias: of:N*T*Cmicrel,ksz8864
> alias: of:N*T*Cmicrel,ks8995C*
> alias: of:N*T*Cmicrel,ks8995
>
> Reported-by: Javier Martinez Canillas <jav...@dowhile0.org>
> Signed-off-by: Daniel Gomez <dag...@gmail.com>
> ---
> drivers/net/phy/spi_ks8995.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
I wonder why this SPI driver is under drivers/net/phy. Just because
the SPI IP is found on an ethernet switch chip? And even then it
would be wrong, I see no link to a PHY at all. I'd say the driver
belongs to drivers/spi. Shouldn't we move it?
