On Thu, 17.12.20 um 02:13 Jakub Kicinski wrote:
Thanks for the patch, minor nits below.
Thanks for the Feedback! I will work it in for my v2.
+
+ if (!(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp))
!a && !b reads better IMHO
We've chosen this variant because it is already
Hi Holger,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 3db1a3fa98808aa90f95ec3e0fa2fc7abf28f5c9]
url:
https://github.com/0day-ci/linux/commits/Holger-Assmann/net-stmmac-retain-PTP-clock-at-hwtstamp_set/20201216-194127
base:3db1a3fa98808aa90f95ec3e0f
On 17.12.20 18:59, Jakub Kicinski wrote:
> On Thu, 17 Dec 2020 09:25:48 +0100 Ahmad Fatoum wrote:
>> On 17.12.20 02:13, Jakub Kicinski wrote:
+ netdev_warn(priv->dev, "HW Timestamping init failed:
%pe\n",
+ ERR_PTR(ret));
>>>
>>> w
On Thu, 17 Dec 2020 09:25:48 +0100 Ahmad Fatoum wrote:
> On 17.12.20 02:13, Jakub Kicinski wrote:
> >> + netdev_warn(priv->dev, "HW Timestamping init failed:
> >> %pe\n",
> >> + ERR_PTR(ret));
> >
> > why convert to ERR_PTR and use %pe and not j
Hello,
On 17.12.20 02:13, Jakub Kicinski wrote:
>> +netdev_warn(priv->dev, "HW Timestamping init failed:
>> %pe\n",
>> +ERR_PTR(ret));
>
> why convert to ERR_PTR and use %pe and not just %d?
To get a symbolic error name if support is compi
On Wed, Dec 16, 2020 at 05:13:34PM -0800, Jakub Kicinski wrote:
> On Wed, 16 Dec 2020 12:32:38 +0100 Holger Assmann wrote:
> > As it is, valid SIOCSHWTSTAMP ioctl calls - i.e. enable/disable time
> > stamping or changing filter settings - lead to synchronization of the
> > NIC's hardware clock with
On Wed, 16 Dec 2020 12:32:38 +0100 Holger Assmann wrote:
> As it is, valid SIOCSHWTSTAMP ioctl calls - i.e. enable/disable time
> stamping or changing filter settings - lead to synchronization of the
> NIC's hardware clock with CLOCK_REALTIME. This might be necessary
> during system initialization,
As it is, valid SIOCSHWTSTAMP ioctl calls - i.e. enable/disable time
stamping or changing filter settings - lead to synchronization of the
NIC's hardware clock with CLOCK_REALTIME. This might be necessary
during system initialization, but at runtime, when the PTP clock has
already been synchronized
