On 17.12.20 18:59, Jakub Kicinski wrote: > On Thu, 17 Dec 2020 09:25:48 +0100 Ahmad Fatoum wrote: >> On 17.12.20 02:13, Jakub Kicinski wrote: >>>> + netdev_warn(priv->dev, "HW Timestamping init failed: >>>> %pe\n", >>>> + ERR_PTR(ret)); >>> >>> why convert to ERR_PTR and use %pe and not just %d? >> >> To get a symbolic error name if support is compiled in (note the `e' after >> %p). > > Cool, GTK. Kind of weird we there is no equivalent int decorator, tho. > Do you happen to know why? New format-specifiers should be using %p<extension>, which is already established, said the reviewers:
https://lore.kernel.org/lkml/20200120085508.25522-1-u.kleine-koe...@pengutronix.de/ -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
