RE: [EXTERNAL] Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-30 Thread Badel, Laurent
emloft.net; alexander.le...@microsoft.com; Quette, Arnaud > > Subject: Re: [EXTERNAL] Re: [PATCH 1/2] Revert commit > 1b0a83ac04e383e3bed21332962b90710fcf2828 > > On Wed, Apr 29, 2020 at 03:48:56PM +, Badel, Laurent wrote: > > Hi Andrew, > > > > Thanks for th

Re: [EXTERNAL] Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread Andrew Lunn
On Wed, Apr 29, 2020 at 03:48:56PM +, Badel, Laurent wrote: > Hi Andrew, > > Thanks for the reply. It's the mainline tree, was 5.6.-rc7 at the time. > There's no tree mentioned for the ethernet PHY library in the maintainers > files, > but am I expected to test against net/ or net-next/ ?

RE: [EXTERNAL] Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread Badel, Laurent
rosoft.com; Quette, Arnaud > > Subject: [EXTERNAL] Re: [PATCH 1/2] Revert commit > 1b0a83ac04e383e3bed21332962b90710fcf2828 > > > Test results: using an iMX28-EVK-based board, this patch successfully > > restores network interface functionality when interrupts are enabled

Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread Andrew Lunn
> Test results: using an iMX28-EVK-based board, this patch successfully > restores network interface functionality when interrupts are enabled. > Tested using both linux-5.4.23 and latest mainline (5.6.0) kernels. Hi Laurent What tree are these patches against? That is why i pointed you to the n

Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread Andrew Lunn
On Wed, Apr 29, 2020 at 09:03:32AM +, Badel, Laurent wrote: > Description: This patch reverts commit 1b0a83ac04e3 > ("net: fec: add phy_reset_after_clk_enable() support") > which produces undesirable behavior when PHY interrupts are enabled. > > Rationale: the SMSC LAN8720 (and possibly othe

Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread Badel, Laurent
> f.faine...@gmail.com; hkallwe...@gmail.com; li...@armlinux.org.uk; > richard.leit...@skidata.com; da...@davemloft.net; > alexander.le...@microsoft.com; Quette, Arnaud > > Subject: Re: [EXTERNAL] Re: [PATCH 1/2] Revert commit > 1b0a83ac04e383e3bed21332962b90710fcf2828 > > On Wed,

Re: [EXTERNAL] Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread gre...@linuxfoundation.org
On Wed, Apr 29, 2020 at 11:22:58AM +, Badel, Laurent wrote: > Dear Greg, > > Thanks for your reply and sorry for my mistake. > Looks to me like the issue is the commit hash which should be 12 chars. > Does that mean I need to fix and resend the whole thing to everyone? Yes please, never fo

RE: [EXTERNAL] Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread Badel, Laurent
kernel.org; and...@lunn.ch; > f.faine...@gmail.com; hkallwe...@gmail.com; li...@armlinux.org.uk; > richard.leit...@skidata.com; da...@davemloft.net; > alexander.le...@microsoft.com; Quette, Arnaud > > Subject: [EXTERNAL] Re: [PATCH 1/2] Revert commit > 1b0a83ac04e383e3bed21332962

Re: [PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread gre...@linuxfoundation.org
On Wed, Apr 29, 2020 at 09:03:32AM +, Badel, Laurent wrote: > Description: This patch reverts commit 1b0a83ac04e3 > ("net: fec: add phy_reset_after_clk_enable() support") > which produces undesirable behavior when PHY interrupts are enabled. > > Rationale: the SMSC LAN8720 (and possibly othe

[PATCH 1/2] Revert commit 1b0a83ac04e383e3bed21332962b90710fcf2828

2020-04-29 Thread Badel, Laurent
Description: This patch reverts commit 1b0a83ac04e3 ("net: fec: add phy_reset_after_clk_enable() support") which produces undesirable behavior when PHY interrupts are enabled. Rationale: the SMSC LAN8720 (and possibly other chips) is known to require a reset after the external clock is enabled.