Re: [PATCH 1/1]: Using ICMP type and code in xfrm selector

2007-11-09 Thread Herbert Xu
On Fri, Nov 02, 2007 at 06:17:40PM -0500, Joy Latten wrote: > > While fixing this I wondered why we put icmp message > type in sport and code in dport? Where we put the info in the kernel is not specified by the RFC. It has to document where you put it in IKE because IKE is used by two systems wh

[PATCH 1/1]: Using ICMP type and code in xfrm selector

2007-11-02 Thread Joy Latten
ICMP message type and/or code may be value "0" when used as selector. Currently, if you specify SPD entry with upper layer protocol set as icmp, specify message type is 0 and code is 0, then all icmp messages get mapped to this. It appears value 0 for port is interpreted to mean ANY, which is no