Re: [PATCH 03/11] net: phy: Check against net_device being NULL

2019-05-28 Thread Andrew Lunn
On Tue, May 28, 2019 at 12:21:59AM +0300, Ioana Ciornei wrote: > In general, we don't want MAC drivers calling phy_attach_direct with the > net_device being NULL. Add checks against this in all the functions > calling it: phy_attach() and phy_connect_direct(). > > Signed-off-by: Ioana Ciornei > S

Re: [PATCH 03/11] net: phy: Check against net_device being NULL

2019-05-28 Thread Andrew Lunn
On Tue, May 28, 2019 at 12:21:59AM +0300, Ioana Ciornei wrote: > In general, we don't want MAC drivers calling phy_attach_direct with the > net_device being NULL. Add checks against this in all the functions > calling it: phy_attach() and phy_connect_direct(). > > Signed-off-by: Ioana Ciornei > S

Re: [PATCH 03/11] net: phy: Check against net_device being NULL

2019-05-27 Thread kbuild test robot
Hi Ioana, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on v5.2-rc2 next-20190524] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

Re: [PATCH 03/11] net: phy: Check against net_device being NULL

2019-05-27 Thread kbuild test robot
Hi Ioana, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on v5.2-rc2 next-20190524] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

[PATCH 03/11] net: phy: Check against net_device being NULL

2019-05-27 Thread Ioana Ciornei
In general, we don't want MAC drivers calling phy_attach_direct with the net_device being NULL. Add checks against this in all the functions calling it: phy_attach() and phy_connect_direct(). Signed-off-by: Ioana Ciornei Suggested-by: Andrew Lunn --- drivers/net/phy/phy_device.c | 6 ++ 1 f