Hi Ioana, I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] [also build test WARNING on v5.2-rc2 next-20190524] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ioana-Ciornei/Decoupling-PHYLINK-from-struct-net_device/20190528-061507 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> sparse warnings: (new ones prefixed by >>) >> drivers/net/phy/phy_device.c:952:31: sparse: sparse: incorrect type in >> return expression (different base types) @@ expected int @@ got voiint >> @@ >> drivers/net/phy/phy_device.c:952:31: sparse: expected int >> drivers/net/phy/phy_device.c:952:31: sparse: got void * vim +952 drivers/net/phy/phy_device.c 937 938 /** 939 * phy_connect_direct - connect an ethernet device to a specific phy_device 940 * @dev: the network device to connect 941 * @phydev: the pointer to the phy device 942 * @handler: callback function for state change notifications 943 * @interface: PHY device's interface 944 */ 945 int phy_connect_direct(struct net_device *dev, struct phy_device *phydev, 946 void (*handler)(struct net_device *), 947 phy_interface_t interface) 948 { 949 int rc; 950 951 if (!dev) > 952 return ERR_PTR(-EINVAL); 953 954 rc = phy_attach_direct(dev, phydev, phydev->dev_flags, interface); 955 if (rc) 956 return rc; 957 958 phy_prepare_link(phydev, handler); 959 if (phy_interrupt_is_valid(phydev)) 960 phy_request_interrupt(phydev); 961 962 return 0; 963 } 964 EXPORT_SYMBOL(phy_connect_direct); 965 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
