On Fri, Aug 12, 2005 at 06:14:39PM +0200, Balazs Scheidler wrote:
> > Whenever I want to sync the upstream tree, i
> > "ln -sf .git/refs/heads/master .git/HEAD; cg-update origin"
Sorry, there is a "cg-reset" missing between the "ln" and the "cg-update"
--
- Harald Welte <[EMAIL PROTECTED]>
On Thu, Aug 11, 2005 at 02:44:11PM +0200, Balazs Scheidler wrote:
> On Thu, 2005-08-11 at 22:31 +1000, Herbert Xu wrote:
> > Balazs Scheidler <[EMAIL PROTECTED]> wrote:
> > >
> > > I've attached a revised patch, this time with complete error checking,
> > > and
> > > propagating the error code to
Balazs Scheidler <[EMAIL PROTECTED]> wrote:
>
> Shall I panic in this case?
Yes please. Just panic at the spot where the allocation fails
rather than going up. BTW, you should CC davem if you'd like
to see your patch included.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbe
On Thu, 2005-08-11 at 14:44 +0200, Balazs Scheidler wrote:
> On Thu, 2005-08-11 at 22:31 +1000, Herbert Xu wrote:
> > Balazs Scheidler <[EMAIL PROTECTED]> wrote:
> > >
> > > I've attached a revised patch, this time with complete error checking,
> > > and
> > > propagating the error code to the ca
On Thu, 2005-08-11 at 22:31 +1000, Herbert Xu wrote:
> Balazs Scheidler <[EMAIL PROTECTED]> wrote:
> >
> > I've attached a revised patch, this time with complete error checking, and
> > propagating the error code to the caller. Please apply.
>
> Sorry, but it seems that you've left out the bits t
Balazs Scheidler <[EMAIL PROTECTED]> wrote:
>
> I've attached a revised patch, this time with complete error checking, and
> propagating the error code to the caller. Please apply.
Sorry, but it seems that you've left out the bits that check the
return value from xfrm_init()?
Thanks,
--
Visit O
On Mon, 2005-08-08 at 16:27 +0200, Balazs Scheidler wrote:
> Is this tiny patchlet worth the trouble of changing
> xfrm_init/xfrm_state_init to return int, and do error checking from
> ip_rt_init() ?
I've attached a revised patch, this time with complete error checking, and
propagating the error
Balazs Scheidler <[EMAIL PROTECTED]> :
[...]
> Is this tiny patchlet worth the trouble of changing
> xfrm_init/xfrm_state_init to return int, and do error checking from
> ip_rt_init() ?
xfrm_policy_init() simply panics when the allocation fails.
A sophisticated error checking can imho be the poin
Sent to myself the first time.
> >
> >
> > @@ -1097,6 +1097,8 @@ void __init xfrm_state_init(void)
> > {
> > int i;
> >
> > + xfrm_state_bydst = (struct list_head *)
> > __get_free_pages(GFP_KERNEL, get_order(sizeof(struct list_head) *
> > XFRM_DST_HSIZE * 2));
> > + xfr
In article <[EMAIL PROTECTED]> (at Sun, 07 Aug 2005 20:33:38 +0200), Balazs
Scheidler <[EMAIL PROTECTED]> says:
> Commit log says it all.
> + xfrm_state_bydst = (struct list_head *) __get_free_pages(GFP_KERNEL,
> get_order(sizeof(struct list_head) * XFRM_DST_HSIZE * 2));
Please check the
Hi,
Commit log says it all.
Signed-off-by: Balazs Scheidler <[EMAIL PROTECTED]>
diff-tree a262e285077cb1604c25c5de99d71bbf739823e2 (from
684a28105211367d9040ee945cead597912cc49e)
Author: Balazs Scheidler <[EMAIL PROTECTED](none)>
Date: Sun Aug 7 20:23:59 2005 +0200
As discussed [1] in a
11 matches
Mail list logo
