On Thu, 2005-08-11 at 14:44 +0200, Balazs Scheidler wrote: > On Thu, 2005-08-11 at 22:31 +1000, Herbert Xu wrote: > > Balazs Scheidler <[EMAIL PROTECTED]> wrote: > > > > > > I've attached a revised patch, this time with complete error checking, > > > and > > > propagating the error code to the caller. Please apply. > > > > Sorry, but it seems that you've left out the bits that check the > > return value from xfrm_init()? > > > > Damn. I still have to get used to with git. Thanks for the hint. Anyone > know a git description that tells me how to follow a tree and maintain > my own set of patches on top? > > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > --- a/net/ipv4/route.c > +++ b/net/ipv4/route.c > @@ -3201,7 +3201,7 @@ int __init ip_rt_init(void) > #endif > #endif > #ifdef CONFIG_XFRM > - xfrm_init(); > + rc = xfrm_init(); > xfrm4_init(); > #endif > return rc; > >
In the meanwhile I found out that the return value of ip_rt_init is never handled, thus the code above is not fully correct, not to mention that xfrm4_init is called even if xfrm_init failed. Shall I panic in this case? -- Bazsi - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
