Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-19 Thread Jason Wang
On 2017年01月20日 06:30, Michael S. Tsirkin wrote: On Thu, Jan 19, 2017 at 11:06:59AM +0800, Jason Wang wrote: On 2017年01月18日 23:18, Michael S. Tsirkin wrote: On Wed, Jan 18, 2017 at 11:54:21AM +0800, Jason Wang wrote: On 2017年01月18日 02:27, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 06

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-19 Thread Michael S. Tsirkin
On Thu, Jan 19, 2017 at 11:06:59AM +0800, Jason Wang wrote: > > > On 2017年01月18日 23:18, Michael S. Tsirkin wrote: > > On Wed, Jan 18, 2017 at 11:54:21AM +0800, Jason Wang wrote: > > > On 2017年01月18日 02:27, Michael S. Tsirkin wrote: > > > > On Tue, Jan 17, 2017 at 06:13:51PM +, Rolf Neugebauer

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-18 Thread Jason Wang
On 2017年01月18日 23:18, Michael S. Tsirkin wrote: On Wed, Jan 18, 2017 at 11:54:21AM +0800, Jason Wang wrote: On 2017年01月18日 02:27, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 06:13:51PM +, Rolf Neugebauer wrote: This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-18 Thread Michael S. Tsirkin
On Wed, Jan 18, 2017 at 11:54:21AM +0800, Jason Wang wrote: > > > On 2017年01月18日 02:27, Michael S. Tsirkin wrote: > > On Tue, Jan 17, 2017 at 06:13:51PM +, Rolf Neugebauer wrote: > > > This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a > > > subtle change in how the virt

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-18 Thread Sergei Shtylyov
Hello! On 1/17/2017 9:13 PM, Rolf Neugebauer wrote: This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a You also need to specify the patch summary lines enclosed in (""). subtle change in how the virtio_net flags are derived from the SKBs ip_summed field. With the a

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-17 Thread Jason Wang
On 2017年01月18日 02:27, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 06:13:51PM +, Rolf Neugebauer wrote: This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a subtle change in how the virtio_net flags are derived from the SKBs ip_summed field. With the above commits

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-17 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 17 Jan 2017 20:27:33 +0200 > On Tue, Jan 17, 2017 at 06:13:51PM +, Rolf Neugebauer wrote: >> This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a >> subtle change in how the virtio_net flags are derived from the SKBs >> ip_summed field

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-17 Thread Michael S. Tsirkin
On Tue, Jan 17, 2017 at 06:13:51PM +, Rolf Neugebauer wrote: > This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a > subtle change in how the virtio_net flags are derived from the SKBs > ip_summed field. > > With the above commits, the flags are set to VIRTIO_NET_HDR_F_DAT

[PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-17 Thread Rolf Neugebauer
This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a subtle change in how the virtio_net flags are derived from the SKBs ip_summed field. With the above commits, the flags are set to VIRTIO_NET_HDR_F_DATA_VALID when ip_summed == CHECKSUM_UNNECESSARY, thus treating it differentl