From: "Michael S. Tsirkin" <m...@redhat.com>
Date: Tue, 17 Jan 2017 20:27:33 +0200

> On Tue, Jan 17, 2017 at 06:13:51PM +0000, Rolf Neugebauer wrote:
>> This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a
>> subtle change in how the virtio_net flags are derived from the SKBs
>> ip_summed field.
>> 
>> With the above commits, the flags are set to VIRTIO_NET_HDR_F_DATA_VALID
>> when ip_summed == CHECKSUM_UNNECESSARY, thus treating it differently to
>> ip_summed == CHECKSUM_NONE, which should be the same.
>> 
>> Further, the virtio spec 1.0 / CS04 explicitly says that
>> VIRTIO_NET_HDR_F_DATA_VALID must not be set by the driver.
>> 
>> Signed-off-by: Rolf Neugebauer <rolf.neugeba...@docker.com>
> 
> Fixes: fd2a0437dc33 ("virtio_net: introduce virtio_net_hdr_{from,to}_skb")
> Fixes: e858fae2b0b8 (" virtio_net: use common code for virtio_net_hdr and skb 
> GSO conversion")
> Acked-by: Michael S. Tsirkin <m...@redhat.com>
> 
> Should be backported into stable as well.

Applied and queued up for -stable, thanks everyone.

Reply via email to