Re: [PATCH] tg3: netif_carrier_off runs too early; could still be queued when init fails

2006-02-22 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Chan wrote: > On Tue, 2006-02-21 at 17:41 -0500, Jeff Mahoney wrote: > >> dmesg after modprobe tg3: >> tg3.c:v3.49 (Feb 2, 2006) >> ACPI: PCI Interrupt :0a:02.0[A] -> GSI 24 (level, low) -> IRQ 201 >> Uhhuh. NMI received for unknown reason

Re: [PATCH] tg3: netif_carrier_off runs too early; could still be queued when init fails

2006-02-21 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 21 Feb 2006 13:57:28 -0800 > On Tue, 2006-02-21 at 17:41 -0500, Jeff Mahoney wrote: > > > dmesg after modprobe tg3: > > tg3.c:v3.49 (Feb 2, 2006) > > ACPI: PCI Interrupt :0a:02.0[A] -> GSI 24 (level, low) -> IRQ 201 > > Uhhuh. NMI received f

Re: [PATCH] tg3: netif_carrier_off runs too early; could still be queued when init fails

2006-02-21 Thread Michael Chan
On Tue, 2006-02-21 at 17:41 -0500, Jeff Mahoney wrote: > > dmesg after modprobe tg3: > tg3.c:v3.49 (Feb 2, 2006) > ACPI: PCI Interrupt :0a:02.0[A] -> GSI 24 (level, low) -> IRQ 201 > Uhhuh. NMI received for unknown reason 21 on CPU 0. > Dazed and confused, but trying to continue > Do you have

Re: [PATCH] tg3: netif_carrier_off runs too early; could still be queued when init fails

2006-02-21 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 David S. Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Tue, 21 Feb 2006 08:44:20 -0800 > >> On Mon, 2006-02-20 at 14:43 -0500, Jeff Mahoney wrote: >>> This patch moves the netif_carrier_off() call from tg3_init_one()-> >>> tg3_ini

Re: [PATCH] tg3: netif_carrier_off runs too early; could still be queued when init fails

2006-02-21 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 21 Feb 2006 08:44:20 -0800 > On Mon, 2006-02-20 at 14:43 -0500, Jeff Mahoney wrote: > > This patch moves the netif_carrier_off() call from tg3_init_one()-> > > tg3_init_link_config() to tg3_open() as is the convention for most > > other networ

Re: [PATCH] tg3: netif_carrier_off runs too early; could still be queued when init fails

2006-02-21 Thread Michael Chan
On Mon, 2006-02-20 at 14:43 -0500, Jeff Mahoney wrote: > This patch moves the netif_carrier_off() call from tg3_init_one()-> > tg3_init_link_config() to tg3_open() as is the convention for most > other network drivers. I think moving netif_carrier_off() later is the right thing to do. We can al