On Mon, 2006-02-20 at 14:43 -0500, Jeff Mahoney wrote: > This patch moves the netif_carrier_off() call from tg3_init_one()-> > tg3_init_link_config() to tg3_open() as is the convention for most > other network drivers.
I think moving netif_carrier_off() later is the right thing to do. We can also move it to the end of tg3_init_one() just before returning 0. > > I was getting a panic after a tg3 device failed to initialize due to DMA > failure. The oops pointed to the link watch queue with spinlock debugging > enabled. Without spinlock debugging, the Oops didn't occur. > > I suspect that the link event was getting queued but not executed until > after the DMA test had failed and the device was freed. The link event > was then operating on freed memory, which could contain anything. With this > patch applied, the Oops no longer occurs. DMA test failed? What NIC device do you have? How did it fail? Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
