Re: [PATCH] tcp: remove improper preemption check in tcp_xmit_probe_skb()

2015-10-21 Thread David Miller
From: Renato Westphal Date: Mon, 19 Oct 2015 18:51:34 -0200 > Commit e520af48c7e5a introduced the following bug when setting the > TCP_REPAIR sockoption: ... > Since tcp_xmit_probe_skb() can be called from process context, use > NET_INC_STATS() instead of NET_INC_STATS_BH(). > > Signed-off-by:

Re: [PATCH] tcp: remove improper preemption check in tcp_xmit_probe_skb()

2015-10-19 Thread Eric Dumazet
On Mon, 2015-10-19 at 18:51 -0200, Renato Westphal wrote: > Commit e520af48c7e5a introduced the following bug when setting the > TCP_REPAIR sockoption: > > > Since tcp_xmit_probe_skb() can be called from process context, use > NET_INC_STATS() instead of NET_INC_STATS_BH(). > > Signed-off-by: Re

[PATCH] tcp: remove improper preemption check in tcp_xmit_probe_skb()

2015-10-19 Thread Renato Westphal
Commit e520af48c7e5a introduced the following bug when setting the TCP_REPAIR sockoption: [ 2860.657036] BUG: using __this_cpu_add() in preemptible [] code: daemon/12164 [ 2860.657045] caller is __this_cpu_preempt_check+0x13/0x20 [ 2860.657049] CPU: 1 PID: 12164 Comm: daemon Not tainted 4