On Mon, 2015-10-19 at 18:51 -0200, Renato Westphal wrote:
> Commit e520af48c7e5a introduced the following bug when setting the
> TCP_REPAIR sockoption:
>
>
> Since tcp_xmit_probe_skb() can be called from process context, use
> NET_INC_STATS() instead of NET_INC_STATS_BH().
>
> Signed-off-by: Renato Westphal <rena...@taghos.com.br>
> ---
> net/ipv4/tcp_output.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 19adedb..d4621c3 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -3416,7 +3416,7 @@ static int tcp_xmit_probe_skb(struct sock *sk, int
> urgent, int mib)
> */
> tcp_init_nondata_skb(skb, tp->snd_una - !urgent, TCPHDR_ACK);
> skb_mstamp_get(&skb->skb_mstamp);
> - NET_INC_STATS_BH(sock_net(sk), mib);
> + NET_INC_STATS(sock_net(sk), mib);
> return tcp_transmit_skb(sk, skb, 0, GFP_ATOMIC);
> }
>
Patch looks good, although its title is a bit strange..
Fixes: e520af48c7e5 ("tcp: add TCPWinProbe and TCPKeepAlive SNMP counters")
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
