Re: [PATCH] pcnet32: fix non-napi packet reception

2007-10-18 Thread Lennart Sorensen
On Wed, Oct 17, 2007 at 05:04:01PM -0700, Don Fry wrote: > I have no objections myself. It has been slowly moving that direction. > First with the napi implementation, default off, labeled experimental. > Then removing experimental and then making the default on. > > If any other user of the pcne

Re: [PATCH] pcnet32: fix non-napi packet reception

2007-10-17 Thread Jeff Garzik
Don Fry wrote: Recent changes to the driver for the new napi API broke the reception of packets when in non-napi mode. The initialization of napi.weight was removed for the non-napi case leaving the value zero. Tested NAPI and non-NAPI on x86_64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --

Re: [PATCH] pcnet32: fix non-napi packet reception

2007-10-17 Thread Don Fry
>In general, we're hoping to remove as many CONFIG_FOO_NAPI as possible, >pushing everybody towards using NAPI. > >Any objection to heading in this direction with pcnet32? > >Jeff I have no objections myself. It has been slowly moving that direction. First with the napi implementation, de

Re: [PATCH] pcnet32: fix non-napi packet reception

2007-10-17 Thread Jeff Garzik
Don Fry wrote: Recent changes to the driver for the new napi API broke the reception of packets when in non-napi mode. The initialization of napi.weight was removed for the non-napi case leaving the value zero. Tested NAPI and non-NAPI on x86_64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --

[PATCH] pcnet32: fix non-napi packet reception

2007-10-17 Thread Don Fry
Recent changes to the driver for the new napi API broke the reception of packets when in non-napi mode. The initialization of napi.weight was removed for the non-napi case leaving the value zero. Tested NAPI and non-NAPI on x86_64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- --- linux-2.6.2